-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #379, Enum with 0 value not shown on Example #452
base: develop
Are you sure you want to change the base?
Conversation
+1 |
My change caused another issue so you might want to close this. see #379 (comment) |
Instead of closing the Pr, you can convert the PR to WIP (Work In Progress) by modifying the title and add WIP as a prefix, and take your time to resolve the side effect. I think these methods are needed to be added:
and I see
|
Sure, I'll give it a try this week or the next |
The best I could do was to change it to: At first I tried replacing the line with this: if (spec.HasDefaultValue() && value.Equals(spec.DefaultValue.FromJust())) return true; but it broke some UnParserExtensionsTests. For example: UnParsing_instance_returns_command_line
The BaseType default was included even though it wasn't supposed to be. |
b211712
to
746885a
Compare
See #379
The bug seems to be caused by
commandline/src/CommandLine/UnParserExtensions.cs
Line 251 in 4d69a38
returned to
commandline/src/CommandLine/UnParserExtensions.cs
Line 124 in 4d69a38
I ran all tests after the change and none of them failed.